[INVALID] Broken TTH search on ADC hubs

If you find any bugs, please post in here. Bugs in the Linux version should be reported on Github.

[INVALID] Broken TTH search on ADC hubs

Postby Delion » 07 Oct 2019, 23:18

Here is all the info: https://youtu.be/tdvXeOfbe3w

The file and its TTH were chosen randomly.
Delion
 
Posts: 4
Joined: 20 Nov 2018, 21:22

Re: Broken TTH search on ADC hubs

Postby maksis » 08 Oct 2019, 08:47

The search is being sent correctly by AirDC++. Seems like lots of clients in that hub are returning junk results (possibly it's a bug in FlylinkDC++). The same thing also happens with other clients, they just generally seem to filter incorrect results locally (check the filtered result count), which isn't needed in ADC hubs, assuming that other clients understand what they are supposed to return...
User avatar
maksis
Site Admin
 
Posts: 874
Joined: 23 Nov 2010, 18:56

Re: Broken TTH search on ADC hubs

Postby Delion » 08 Oct 2019, 13:20

FlylinkDC++?..
https://github.com/pavel-pimenov/flylin ... ssues/1727
You mean THAT bug?

Can't AirDC++ filter results too?
Delion
 
Posts: 4
Joined: 20 Nov 2018, 21:22

Re: Broken TTH search on ADC hubs

Postby maksis » 08 Oct 2019, 17:40

That might be the bug...

Delion wrote:Can't AirDC++ filter results too?


The goal is that the responding client knows what to return. Local filtering was implemented only because of NMDC but it's not required in ADC hubs. Other clients that are based on DC++ probably still use the same filtering code for both results, while AirDC++ doesn't do that. I'm not that fond of doing local filtering only because certain clients are spamming junk results.
User avatar
maksis
Site Admin
 
Posts: 874
Joined: 23 Nov 2010, 18:56


Return to Bug Reports

Who is online

Users browsing this forum: MSN [Bot] and 1 guest

cron