[FIXED] Bug downloading multipart files in 2.41-2.43

If you find any bugs, please post in here. Bugs in the Linux version should be reported on Github.

[FIXED] Bug downloading multipart files in 2.41-2.43

Postby forkicks » 30 Jan 2013, 15:30

Downloading any file with multiple parts in 2.41 or 2.42 i get the following on any transfer:

Capture2.png


Downloads never end, every now and then the downloaded percentage drops a bit, then rises to values before the drop (130%, 131%, 105%, 106%...150%, 151%, 140%, 141%) and never complete.

Reverting to 2.40, the same file, with the same sources, downloads and finishes without problems. This happens for all downloads. Uploads work fine.
You do not have the required permissions to view the files attached to this post.
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 30 Jan 2013, 17:35

My system specs (missing from the op):

i7 3820 (x79)
32GB ram
running Windows Server 2012 (which is the same as windows 8, for what this is concerned).
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 30 Jan 2013, 21:47

I can confirm this bug... and 2.41-2.42 were meant to improve segmented transfers, bah!
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 12 Feb 2013, 14:12

Please try 2.43 as it should fix the problem. It also fixes various other problems related to segmented downloads that have been there since versions 2.20/2.30.
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 13 Feb 2013, 14:44

Hello

I can confirm it's fixed on 2.43 beta. Thank you very much.

fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 27 Feb 2013, 17:08

And i spoke too soon.

It no longer happens on ALL downloads, but the bug is still present, and this time its more difficult to trigger. While downloading around 20 files (roughly 20/30 mb each, different sizes), 1 or 2 will have the same symptom AND, to make matters worse, when segmented downloading is turned off to actually get them to finish, the files are corrupted.

fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 28 Feb 2013, 00:38

Can you see any difference on those files that have problems? How many downloads do those files have and on what speed?
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 28 Feb 2013, 15:50

Nothing stands out as obvious. As i said, its more difficult to trigger now, and i haven't found a repeatable way to do it. Sometimes i get 10 files in a row without problems, with 8 segments each, downloading properly. Other times, i get 2 or 3 in a row with the problem described above. At the start, they are all similar, downloading at comparable speeds (around 1MB/s) from 4 or 5 sources, but then some will go over 100% and start showing the symptoms i described before.

I -am- trying to establish a pattern to reproduce this on demand to make it easier to fix, but i haven't yet been successful.

All files i download through airdc++ are in the 20 to 30 MB range, all from multiple sources for segmented downloading. I have segmented download set to manually use 8 segments instead of the default automatic 5, but this doesn't affect the problem, as both ways cause it. Removing segmented downloads from the equation by disabling it or downgrading to 2.40 fixes this and lets the files be downloaded properly. Also, the same files that had problems before, if retried (by manually removing them from the file list and downloading again), will sometimes download correctly. Of course, they probably will use different sources, but i can't control that.

fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 13 Mar 2013, 17:29

Still haven't been able to pinpoint a reproducible pattern for this, but it still happens. What i have noticed tho, is that the percentage downloaded shown in the transfer list is different from the one in the download queue (which is correct, and always ends at 100%). Perphaps use the same calculation to display the transfer list percentage would be a good way to go.

fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 14 Mar 2013, 00:53

forkicks wrote:Still haven't been able to pinpoint a reproducible pattern for this, but it still happens. What i have noticed tho, is that the percentage downloaded shown in the transfer list is different from the one in the download queue (which is correct, and always ends at 100%). Perphaps use the same calculation to display the transfer list percentage would be a good way to go.

fK


If the same segments keep on getting downloaded multiple times, I don't think that the progress display is a relevant problem there (or have I misunderstood something?). I'll try set up a test for reproducing this soon.
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 14 Mar 2013, 10:11

Do you get any more information about the problem if you look at the graphical segment presentation on the queue tab? Which segments get downloaded over and over again there (are they finished ones)? Does the problem stay with the specified files also after restarting the client?
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 14 Mar 2013, 13:28

This is really tough to track down. It's not reproducible at will in no way i can discern. It just happens sometimes.

The relation between the download problem and the display is that the files with problem will show a difference between what is shown in the download queue list and the transfer list. The ones with problems will just have the % increases i described in the original post (while showing normal values under the download queue). Its probably the same blocks that are having problems.

I have noticed that those files have many sources and it -may- be a problem on the other end. I've noticed those files, when the first blocks are pulled from a group of specific peers, will almost always exhibit this behaviour and will show a warning that its the wrong file from all other sources. Could this be something on the other end rather than mine? Shouldnt the hash ensure its the same file? Still, it just happens on some files, others will download from those same sources without problems, and i'm not even 100% sure of this connection.

fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 17 Mar 2013, 16:26

I've managed to make this happen once now so there is hope to get it fixed. I see no way how the problem could be caused by the other user.
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 20 Mar 2013, 13:22

Thanks for looking into this, it's really annoying if you're not paying attention to the downloads, and then you're not sure what files are ok/broken.

Cheers,
fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 29 Mar 2013, 21:55

Please try this version if it makes any difference: http://beta.airdcpp.net/airdcpp_2.43_x64_segmenttest.7z (other than the progress display will be more wrong)
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 03 Apr 2013, 17:01

The version you posted fixes the file corruption. The visual percentage error still happens, but at least those files finish eventually and are not broken. In the download queue view, the percentage shown is always correct, its just the active download percentages that are wrong.

It's usable this way.

Thanks,
fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 03 Apr 2013, 19:54

If you are absolutely sure that the previous version works, try this one to see if the progress display is correct: http://beta.airdcpp.net/airdcpp_2.43_x6 ... est_new.7z
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 04 Apr 2013, 10:10

Unfortunately, i seem to be jumping the gun quite often with this problem. Probably just to eager to see it working.

Anyway, just before trying the latest download you posted, i ran another batch of downloads, and it happened again, out of 14, 2 files showed the same behaviour and were corrupted.

Are you absolutely sure this can't be caused by the other end? Because again i noticed that on those files, while they had 50 or 60 sources each, most of those sources were shown as having wrong file or size and refused to download parts. To get them to download properly, i had to actually try a couple of times, and on the times that worked, the reverse happened, only one or two sources showed that message while all the others happily sent parts.

fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 04 Apr 2013, 13:58

forkicks wrote:most of those sources were shown as having wrong file or size and refused to download parts


Where was the wrong size shown? In file list?
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 04 Apr 2013, 22:20

In the transfers list (bottom pane). When the transfer item was expanded to show all the sources, instead of queue position or connecting, some would have a message mentioning wrong size or wrong file, i didn't write down the exact wording.

fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 09 Apr 2013, 11:38

Here ya go. I only see this in files that have this problem:

airdc.png


Hope this helps.
fK
You do not have the required permissions to view the files attached to this post.
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 09 Apr 2013, 16:39

User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 09 Apr 2013, 19:27

The version you posted crashes as soon as a file starts to download.

fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby maksis » 09 Apr 2013, 19:45

Sorry, this one has even been tested: http://beta.airdcpp.net/airdcpp_2.43_x6 ... nttest4.7z
User avatar
maksis
Site Admin
 
Posts: 911
Joined: 23 Nov 2010, 18:56

Re: Bug downloading multipart files in 2.41 and 2.42, ok in

Postby forkicks » 17 Apr 2013, 18:32

The last version you posted works fine. Can't reproduce this again, and i've tried it -alot-.

fK
forkicks
 
Posts: 15
Joined: 30 Jan 2013, 15:13


Return to Bug Reports

Who is online

Users browsing this forum: No registered users and 4 guests